src: remove MarkIndependent() calls
#20108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method has been deprecated in upstream V8, with messaging indicating that it is the default for handles to be independent now anyway. Refs: v8/v8@71ad48f
addaleax
added
v8 engine
nodejs-github-bot
added
c++
Member
Author
apapirovski
approved these changes
Apr 17, 2018
BridgeAR
approved these changes
Apr 17, 2018
jasnell
approved these changes
Apr 17, 2018
tniessen
approved these changes
Apr 17, 2018
addaleax
added
the
author ready
cjihrig
approved these changes
Apr 17, 2018
Contributor
|
Landed in 1f3fbd4 |
apapirovski
pushed a commit
that referenced
this pull request
Apr 22, 2018
The method has been deprecated in upstream V8, with messaging indicating that it is the default for handles to be independent now anyway. PR-URL: #20108 Refs: v8/v8@71ad48f Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 23, 2018
The method has been deprecated in upstream V8, with messaging indicating that it is the default for handles to be independent now anyway. PR-URL: #20108 Refs: v8/v8@71ad48f Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method has been deprecated in upstream V8, with messaging
indicating that it is the default for handles to be independent
now anyway.
Refs: v8/v8@71ad48f
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes