doc: improve buf.write() text in buffer.md #20115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use present tense consistently in parameters description. * Wrap at 80 characters. * "partial amount of `string`" -> "part of `string`" * Unnecessary `Buffer.allocUnsafe()` changed to `Buffer.alloc()`.
nodejs-github-bot
added
buffer
Member
Author
vsemozhetbyt
added
the
fast-track
vsemozhetbyt
approved these changes
Apr 17, 2018
vsemozhetbyt
added
the
author ready
BridgeAR
approved these changes
Apr 18, 2018
trivikr
approved these changes
Apr 18, 2018
jasnell
approved these changes
Apr 18, 2018
lpinca
approved these changes
Apr 19, 2018
|
|
||
| ```js | ||
| const buf = Buffer.allocUnsafe(256); | ||
| const buf = Buffer.alloc(256); |
Member
There was a problem hiding this comment.
Nit: why not using the exact expected size?
Contributor
There was a problem hiding this comment.
If we do this, we can simplify the line below into just console.log(`${len} bytes: ${buf}`);, but this can become less educative)
Member
Author
|
Landed in 76f5b39 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 20, 2018
* Use present tense consistently in parameters description. * Wrap at 80 characters. * "partial amount of `string`" -> "part of `string`" * Unnecessary `Buffer.allocUnsafe()` changed to `Buffer.alloc()`. PR-URL: nodejs#20115 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 20, 2018
* Use present tense consistently in parameters description. * Wrap at 80 characters. * "partial amount of `string`" -> "part of `string`" * Unnecessary `Buffer.allocUnsafe()` changed to `Buffer.alloc()`. PR-URL: #20115 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
string" -> "part ofstring"Buffer.allocUnsafe()changed toBuffer.alloc().Checklist