lib: remove unused binding const #20144
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the binding const as it is only used in one place which is in the following line.
Contributor
Author
lpinca
approved these changes
Apr 19, 2018
lib/_tls_common.js
Outdated
|
|
||
| const binding = process.binding('crypto'); | ||
| const NativeSecureContext = binding.SecureContext; | ||
| const NativeSecureContext = process.binding('crypto').SecureContext; |
Member
There was a problem hiding this comment.
Nit: const { SecureContext: NativeSecureContext } = process.binding('crypto');
Contributor
Author
There was a problem hiding this comment.
I was unsure if that should be changed or not because of the different names. I'm happy to change this though if this is the preferred syntax. Do you know if it is? Thx
Member
There was a problem hiding this comment.
That still keeps the name to NativeSecureContext so I think it's fine.
Contributor
Author
cjihrig
approved these changes
Apr 19, 2018
jasnell
approved these changes
Apr 19, 2018
richardlau
approved these changes
Apr 20, 2018
TimothyGu
approved these changes
Apr 20, 2018
hiroppy
approved these changes
Apr 20, 2018
trivikr
approved these changes
Apr 20, 2018
tniessen
approved these changes
Apr 20, 2018
Member
|
Rerun for node-test-commit-osx https://ci.nodejs.org/job/node-test-commit-osx/17984/ |
BridgeAR
added
the
author ready
Contributor
|
Landed in aaea706 |
apapirovski
pushed a commit
that referenced
this pull request
Apr 22, 2018
This commit removes the binding const as it is only used in one place which is in the following line. PR-URL: #20144 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
jasnell
pushed a commit
that referenced
this pull request
Apr 23, 2018
This commit removes the binding const as it is only used in one place which is in the following line. PR-URL: #20144 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the binding const as it is only used in one place
which is in the following line.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes