Skip to content

doc: add hiding comments note to contributor guide #20149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vsemozhetbyt wants to merge 1 commit into from
Closed

doc: add hiding comments note to contributor guide #20149

vsemozhetbyt wants to merge 1 commit into from

Conversation

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Apr 19, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Please, correct me if this is not well-placed or well-worded.

@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Apr 19, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 19, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 19, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/551/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 19, 2018
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 19, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 19, 2018

Please, add 👍 here to approve fast-tracking.

vsemozhetbyt added a commit that referenced this pull request Apr 19, 2018
@vsemozhetbyt
doc: add hiding comments note to contributor guide
810597d 
PR-URL: #20149
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 19, 2018

Landed in 810597d

@vsemozhetbyt vsemozhetbyt deleted the doc-hide-comments branch April 19, 2018 19:12
jasnell pushed a commit that referenced this pull request Apr 19, 2018
@vsemozhetbyt @jasnell
doc: add hiding comments note to contributor guide
9566603 
PR-URL: #20149
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@ryzokuken ryzokuken ryzokuken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vsemozhetbyt @jasnell @benjamingr @BridgeAR @ryzokuken @nodejs-github-bot