Skip to content

crypto: fix explanation in CipherBase::SetAuthTag #20197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tniessen wants to merge 1 commit into from
Closed

crypto: fix explanation in CipherBase::SetAuthTag #20197

tniessen wants to merge 1 commit into from

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Apr 21, 2018

The semantics of the conditional assignment here are closer to std::min than std::max.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Apr 21, 2018
@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 21, 2018
@tniessen
Copy link
Member Author

tniessen commented Apr 21, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/569/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2018
@tniessen
Copy link
Member Author

tniessen commented Apr 22, 2018

Landed in 854f840.

@tniessen tniessen closed this Apr 22, 2018
tniessen added a commit that referenced this pull request Apr 22, 2018
@tniessen
crypto: fix explanation in CipherBase::SetAuthTag
854f840 
PR-URL: #20197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 23, 2018
@tniessen @jasnell
crypto: fix explanation in CipherBase::SetAuthTag
f274e69 
PR-URL: #20197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@tniessen tniessen removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen @addaleax @lpinca @cjihrig @BridgeAR @nodejs-github-bot