Skip to content

Conversation

@vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Fixes: #20192

@vsemozhetbyt vsemozhetbyt added meta Issues and PRs related to the general management of the project. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 21, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 21, 2018
@vsemozhetbyt
Copy link
Contributor Author

Please, add 👍 here to approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor Author

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2018
vsemozhetbyt added a commit that referenced this pull request Apr 22, 2018
PR-URL: #20200
Fixes: #20192
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@vsemozhetbyt
Copy link
Contributor Author

Landed in 5389c92

@vsemozhetbyt vsemozhetbyt deleted the doc-ci-rerun-job branch April 22, 2018 00:09
jasnell pushed a commit that referenced this pull request Apr 23, 2018
PR-URL: #20200
Fixes: #20192
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants