build: add '-z relro -z now' linker flags #20513
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These flags could make some sections and the GOT entries of node process read only to avoid being modified after dynamic linking is done, thus the security could be enhanced. Fixes: nodejs#20122
nodejs-github-bot
added
the
build
bnoordhuis
approved these changes
May 4, 2018
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM. Labeling semver-major.
CI: https://ci.nodejs.org/job/node-test-pull-request/14662/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1395/
bnoordhuis
added
the
semver-major
TimothyGu
approved these changes
May 4, 2018
cjihrig
approved these changes
May 5, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
May 6, 2018
Contributor
Author
|
@bnoordhuis Thanks for trigger the CI test. |
Member
|
@tingshao Looks like a flaky test, probably nothing to worry about. citgm looks okay too, insofar as I can decode the results. |
Member
|
Landed in 2d4dd10 🎉 |
addaleax
pushed a commit
that referenced
this pull request
May 14, 2018
These flags could make some sections and the GOT entries of node process read only to avoid being modified after dynamic linking is done, thus the security could be enhanced. Fixes: #20122 PR-URL: #20513 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These flags could make some sections and the GOT entries of node
process read only to avoid being modified after dynamic linking is
done, thus the security could be enhanced.
Fixes: #20122
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes