util: change items unknown style #20792
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We mainly use <> to visualize special information that is not directly visible as property.
nodejs-github-bot
added
the
util
Member
Author
|
CI https://ci.nodejs.org/job/node-test-pull-request/14917/ (About semver: I am somewhat on the edge if this is a bugfix or semver-major). |
Member
Is there a downside to semver-major? |
addaleax
approved these changes
May 16, 2018
addaleax
added
the
semver-major
Member
Author
No ^^ |
jasnell
approved these changes
May 16, 2018
targos
approved these changes
May 17, 2018
danbev
approved these changes
May 17, 2018
trivikr
approved these changes
May 17, 2018
BridgeAR
added
the
author ready
cjihrig
approved these changes
May 17, 2018
lpinca
approved these changes
May 18, 2018
devsnek
approved these changes
May 18, 2018
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
May 20, 2018
We mainly use <> to visualize special information that is not directly visible as property. PR-URL: nodejs#20792 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
tniessen
approved these changes
May 20, 2018
Member
Author
|
Landed in e270ae9 |
targos
removed
the
author ready
ghost
deleted a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mainly use <> to visualize special information that is not
directly visible as property.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes