Skip to content

tools: fix typo in .eslintrc.js #21449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
boneskull wants to merge 1 commit into from
Closed

tools: fix typo in .eslintrc.js #21449

boneskull wants to merge 1 commit into from

Conversation

@boneskull
Copy link
Member

@boneskull boneskull commented Jun 21, 2018

Refs: #18566

astrictEqual is not a thing.

Checklist

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 21, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jun 21, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jun 21, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/887/
(Please, run full CI if needed.)

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 21, 2018
@tniessen
Copy link
Member

tniessen commented Jun 21, 2018

Fast-tracking has been approved.

@Trott
Copy link
Member

Trott commented Jun 21, 2018

Landed in 2f1a23e

Thanks!

@Trott Trott closed this Jun 21, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 21, 2018
@boneskull @Trott
tools: fix typo in .eslintrc.js
2f1a23e 
Refs: nodejs#18566

PR-URL: nodejs#21449
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jun 22, 2018
@boneskull @targos
tools: fix typo in .eslintrc.js
a1580a0 
Refs: #18566

PR-URL: #21449
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@boneskull boneskull deleted the eslintrc-typo-fix branch June 22, 2018 18:22
@targos targos mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@boneskull @vsemozhetbyt @tniessen @Trott @lpinca @cjihrig @richardlau @nodejs-github-bot