Skip to content

doc: fix list format in cli.md #21467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vsemozhetbyt wants to merge 1 commit into from
Closed

doc: fix list format in cli.md #21467

vsemozhetbyt wants to merge 1 commit into from

Conversation

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jun 22, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, I've messed this up in #21229.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 22, 2018

@vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/122/pipeline

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Jun 22, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Jun 22, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 22, 2018
vsemozhetbyt added a commit that referenced this pull request Jun 22, 2018
@vsemozhetbyt
doc: fix list format in cli.md
a40e062 
PR-URL: #21467
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Jun 22, 2018

Landed in a40e062
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the doc-cli-list-format branch June 22, 2018 20:42
targos pushed a commit that referenced this pull request Jun 24, 2018
@vsemozhetbyt @targos
doc: fix list format in cli.md
361e4f2 
PR-URL: #21467
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vsemozhetbyt @nodejs-github-bot @lpinca @richardlau