Skip to content

doc: state callback behavior on empty buffer #22461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RubenVerborgh wants to merge 1 commit into from
Closed

doc: state callback behavior on empty buffer #22461

RubenVerborgh wants to merge 1 commit into from

Conversation

@RubenVerborgh
Copy link
Contributor

@RubenVerborgh RubenVerborgh commented Aug 22, 2018

Proposed suggestion for #22066 as requested by @mcollina.

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Aug 22, 2018
@RubenVerborgh RubenVerborgh mentioned this pull request Aug 22, 2018
Closed
mcollina
mcollina reviewed Aug 22, 2018
View reviewed changes
doc/api/http.md Outdated
Copy link
Member

@mcollina mcollina Aug 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this and the empty line afterwards.

Copy link
Contributor Author

@RubenVerborgh RubenVerborgh Aug 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back.

@mscdex
Copy link
Contributor

mscdex commented Aug 22, 2018

The subsystem prefix for doc-only changes should be doc: instead of a specific subsystem name like http:.

@RubenVerborgh
Copy link
Contributor Author

RubenVerborgh commented Aug 22, 2018

@mscdex Fixed.

@mscdex mscdex changed the title http: state callback behavior on empty buffer doc: state callback behavior on empty buffer Aug 22, 2018
mcollina
mcollina approved these changes Aug 23, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

mcollina commented Aug 23, 2018

Please 🎉 for fast-track.

@mcollina
Copy link
Member

mcollina commented Aug 23, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/637/

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 23, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Aug 23, 2018

Landed in f7273ed
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Aug 23, 2018
@RubenVerborgh @vsemozhetbyt
doc: state callback behavior on empty buffer
f7273ed 
PR-URL: #22461
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos pushed a commit that referenced this pull request Aug 24, 2018
@RubenVerborgh @targos
doc: state callback behavior on empty buffer
b7c0a78 
PR-URL: #22461
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
@RubenVerborgh @targos
doc: state callback behavior on empty buffer
2a849ba 
PR-URL: #22461
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@targos targos mentioned this pull request Sep 5, 2018
Merged
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

+1 more reviewer

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@RubenVerborgh @mscdex @mcollina @vsemozhetbyt @jasnell @lpinca @BridgeAR @trivikr @nodejs-github-bot