Skip to content

Conversation

@rubys
Copy link
Member

@rubys rubys commented Sep 5, 2018

handle exports. as an alternative to module.exports

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

handle exports. as an alternative to module.exports
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Sep 5, 2018
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 5, 2018
@rubys
Copy link
Member Author

rubys commented Sep 8, 2018

@rubys
Copy link
Member Author

rubys commented Sep 8, 2018

Landed in 8737683

@rubys rubys closed this Sep 8, 2018
rubys added a commit to rubys/node that referenced this pull request Sep 8, 2018
handle exports. as an alternative to module.exports

PR-URL: nodejs#22706
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 9, 2018
handle exports. as an alternative to module.exports

PR-URL: #22706
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants