Skip to content

doc: add missing options for crypto sign.sign() #22824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbj36 wants to merge 1 commit into from
Closed

doc: add missing options for crypto sign.sign() #22824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/api/crypto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,6 +1121,8 @@ changes:
* `privateKey` {string | Object}
- `key` {string}
- `passphrase` {string}
- `padding` {integer}
Copy link
Member

@Trott Trott Sep 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it seems sensible to keep key and passphrase near each other, but I wonder if we would be best to alphabetize the options always. Especially in crypto, the options lists can get long and having a clear and obvious ordering is helpful when you're looking for that one option you care about.

Copy link
Contributor

@vsemozhetbyt vsemozhetbyt Sep 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion: #22874

- `saltLength` {integer}
* `outputFormat` {string}
* Returns: {Buffer | string}

Expand Down