src: flip Atomics.notify alias #22844
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
added
the
lib / src
3 tasks
Contributor
|
I prefer this approach, but I don't think it's up to me to decide, I only wish. :) LGTM |
jdalton
approved these changes
Sep 13, 2018
Member
Author
2 tasks
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Sep 18, 2018
This reverts commit f5d29d5. It also updates the shim to use shim `wake` using `notify`. Refs: nodejs#565 Refs: nodejs#567 Refs: nodejs/node#22844
4 tasks
kfarnung
approved these changes
Sep 18, 2018
Member
Author
|
landed in a7b59d6 |
devsnek
force-pushed
the
realias-atomics-wake
branch
from
ae34cc5 to
a7b59d6
Compare
devsnek
added a commit
to devsnek/node
that referenced
this pull request
Sep 18, 2018
PR-URL: nodejs#22844 Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Member
|
I added the dont-land-on labels because v8/v8@c79206b363 is in V8 7.0 and we won't have this version in current releases. Please correct me if I'm wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #22830
Closes #21219
cc @nodejs/v8 @rwaldron @leobalter
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes