Skip to content

Conversation

@oyyd
Copy link
Contributor

@oyyd oyyd commented Oct 10, 2018

These code snippets are also used in addon tests.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Oct 10, 2018
@oyyd oyyd changed the title doc: fix deprecation warnings of ToObject() in addons.md doc: fix deprecation warnings from ToObject() in addons.md Oct 10, 2018
These code snippets are also used in addon tests.
@danbev
Copy link
Contributor

danbev commented Oct 10, 2018

I think this might be a duplicate of #23323.

@oyyd
Copy link
Contributor Author

oyyd commented Oct 10, 2018

Yes. I didn't notice that. Will close.

@oyyd oyyd closed this Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants