src: throw if functions used as constructors in node_crypto.cc #23582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw an error if verify_error_getter_templ or verify_error_getter_templ2 are used as constructors.
nodejs-github-bot
added
c++
targos
added
the
code-and-learn
addaleax
approved these changes
Oct 12, 2018
jasnell
approved these changes
Oct 12, 2018
Member
addaleax
added
the
author ready
4 tasks
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/17787 |
cjihrig
approved these changes
Oct 13, 2018
gireeshpunathil
approved these changes
Oct 13, 2018
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/17801 ✔️ |
thefourtheye
approved these changes
Oct 13, 2018
Contributor
thefourtheye
left a comment
thefourtheye
left a comment
There was a problem hiding this comment.
/ping @TimothyGu as their TODO comments are cleared here.
TimothyGu
approved these changes
Oct 13, 2018
Member
|
Landed in 20b3698 Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
addaleax
pushed a commit
that referenced
this pull request
Oct 14, 2018
Throw an error if verify_error_getter_templ or verify_error_getter_templ2 are used as constructors. PR-URL: #23582 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Throw an error if verify_error_getter_templ or verify_error_getter_templ2 are used as constructors. PR-URL: #23582 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw an error if verify_error_getter_templ or
verify_error_getter_templ2 are used as constructors.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes