Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/internal/process/per_thread.js
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,10 @@ function wrapProcessMethods(binding) {
process._exiting = true;
process.emit('exit', process.exitCode || 0);
}
binding.reallyExit(process.exitCode || 0);
// FIXME(joyeecheung): This is an undocumented API that gets monkey-patched
// in the user land. Either document it, or deprecate it in favor of a
// better public alternative.
process.reallyExit(process.exitCode || 0);
}

function kill(pid, sig) {
Expand Down
17 changes: 17 additions & 0 deletions test/parallel/test-process-really-exit.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
'use strict';
require('../common');
const assert = require('assert');

// ensure that the reallyExit hook is executed.
// see: https://github.com/nodejs/node/issues/25650
if (process.argv[2] === 'subprocess') {
process.reallyExit = function() {
console.info('really exited');
};
process.exit();
} else {
const { spawnSync } = require('child_process');
const out = spawnSync(process.execPath, [__filename, 'subprocess']);
const observed = out.output[1].toString('utf8').trim();
assert.strictEqual(observed, 'really exited');
}