Skip to content

Revert "stream: make sure 'readable' is emitted before ending the stream #26617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cjihrig wants to merge 1 commit into from
Closed

Revert "stream: make sure 'readable' is emitted before ending the stream #26617

cjihrig wants to merge 1 commit into from

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 12, 2019

This reverts commit e95e7f9.

It was identified as causing breakage for Node 12.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 12, 2019

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2884/pipeline

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Mar 12, 2019
@cjihrig cjihrig mentioned this pull request Mar 12, 2019
Closed
@lpinca
Copy link
Member

lpinca commented Mar 12, 2019 •
edited
Loading

Should #25810 be reopened if/when this lands?

mcollina
mcollina approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

mcollina commented Mar 12, 2019

Yes, that should be reopened.

@mcollina mcollina mentioned this pull request Mar 12, 2019
Closed
@mcollina
Copy link
Member

mcollina commented Mar 13, 2019

Alternative fix, please check: #26643

@mcollina mcollina mentioned this pull request Mar 13, 2019
Closed
3 tasks
@mcollina
Copy link
Member

mcollina commented Mar 16, 2019

Closing because of 269103a

@mcollina mcollina closed this Mar 16, 2019
@cjihrig cjihrig deleted the revert branch March 16, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@lpinca lpinca lpinca approved these changes

Assignees

No one assigned

Labels

stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cjihrig @nodejs-github-bot @lpinca @mcollina