Skip to content

test: move test that creates 1Gb file to pummel #27053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
refack merged 1 commit into from
Apr 2, 2019
Merged

test: move test that creates 1Gb file to pummel #27053

refack merged 1 commit into from
Apr 2, 2019

Conversation

@Trott
Copy link
Member

@Trott Trott commented Apr 2, 2019

Fixes: #16601

Collaborators, please 👍 here if you approve fast-tracking.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 2, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 2, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3143

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 2, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 2, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22117/

@Trott @refack
test: move test that creates 1Gb file to pummel
82bf240 
Fixes: nodejs#16601

PR-URL: nodejs#27053
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@refack refack force-pushed the mv-largefile-to-pummel branch from 06a6ef5 to 82bf240 Compare April 2, 2019 11:55
@refack refack merged commit 82bf240 into nodejs:master Apr 2, 2019
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@Trott @BethGriggs
test: move test that creates 1Gb file to pummel
713b34f 
Fixes: #16601

PR-URL: #27053
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@Trott @BethGriggs
test: move test that creates 1Gb file to pummel
2c1892d 
Fixes: #16601

PR-URL: #27053
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@Trott @BethGriggs
test: move test that creates 1Gb file to pummel
ecac654 
Fixes: #16601

PR-URL: #27053
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@Trott @BethGriggs
test: move test that creates 1Gb file to pummel
687348a 
Fixes: #16601

PR-URL: #27053
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@Trott Trott deleted the mv-largefile-to-pummel branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test-fs-readfile-tostring-fail

5 participants

@Trott @nodejs-github-bot @refack @targos @ZYSzys