-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
stream: use readableObjectMode public api for js stream #27655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think we need to add some tests for this. |
|
@mcollina PTAL.. Also, if getters/setters to be added in the prototype, I guess we need to document those as well. |
98fae1c to
334b049
Compare
334b049 to
9cf3e3b
Compare
|
Did you benchmark this? getters used to add a noticeable overhead over direct property access. |
9cf3e3b to
cd0f124
Compare
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as request changes. Would you mind removing the setters?
addaleax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the setters removed
cd0f124 to
6cb7983
Compare
6cb7983 to
08d0cef
Compare
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Landed in b4735ec 🎉 |
Added
readableObjectModeandwritableObjectModeto stream, so that we can remove instances like_readableState.*in code.Refs: #445
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes