Skip to content

Conversation

@bnb
Copy link
Contributor

@bnb bnb commented Jun 7, 2019

Was looking at the README and noticed that two links were outdated:

  • The Node.js website link was broken.
  • There was still a reference to the Node.js Foundation, rather than the OpenJS Foundation.

Figured I could just PR rather than bothering someone else about it 💖

@nodejs-github-bot
Copy link
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 7, 2019
@richardlau
Copy link
Member

#28042 from a first time contributor also seeks to address the broken website link.

@Trott
Copy link
Member

Trott commented Jun 10, 2019

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 10, 2019
@Trott Trott mentioned this pull request Jun 13, 2019
2 tasks
@Trott
Copy link
Member

Trott commented Jun 13, 2019

Landed in 0a3885e

@Trott Trott closed this Jun 13, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 13, 2019
PR-URL: nodejs#28119
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
PR-URL: #28119
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
@devsnek devsnek deleted the bnb/update-readme-markdown-links branch August 14, 2019 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants