-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
stream: finished cleanup #28820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: finished cleanup #28820
Conversation
157348b to
e66269c
Compare
Heap dumps can be taken either through the inspector or the public API for it during an async_hooks init() hook, but at that point the AsyncWrap in question is not done initializing yet and virtual methods cannot be called on it. Address this issue (somewhat hackily) by excluding `AsyncWrap` instances which have not yet executed their `init()` hook fully from heap dumps. Fixes: nodejs#28786 PR-URL: nodejs#28789 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
ce88059 to
77bfb20
Compare
|
Even though the GitHub interface isn't complaining about it, I think this might need a rebase? This doesn't apply cleanly for me on |
|
Perhaps another commit was accidentally amended with the changes from this PR? |
|
@Trott Using 3-way |
Oh, of course, |
|
This is blocked by #28818 |
|
If the user wants cleanup they can just call the callback. e.g. const cleanup = finished(...streams, err => {
cleanup();
// ...
}); |
finishedshould not leave dangling listeners and leave the stream in the same state after as before.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes