stream: writableComplete #28968
Closed
stream: writableComplete #28968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
Member
Author
|
ping @mcollina thoughts? |
ronag
force-pushed
the
stream-writablecomplete
branch
from
bd7ad6f to
3999edb
Compare
ronag
force-pushed
the
stream-writablecomplete
branch
from
3999edb to
54b2d81
Compare
Member
|
I'm not sure about this one. I think |
Member
Author
|
@mcollina: Convenience. Also the check is a bit more complicated on the |
Member
|
@nodejs/streams |
mcollina
requested changes
Aug 9, 2019
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
I'm -1 of adding this, as that state data is already exposed in other accessors
Member
Author
|
There is something with http here that might need further thinking but I can't remember what it was. Will close for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a suggestion. Would like to see if there is any traction behind it.
It is quite common (at least in http and middleware) to check whether any further useful work can be performed on a writable stream. This is a bit similar to
onFinished.isFinished.We also already have it here: https://github.com/nodejs/node/blob/master/lib/internal/http2/compat.js#L304
Replaces #28628
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes