Skip to content

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Oct 18, 2019

Original commit message:

[build] Add missing header to build (regexp/special-case.h)

This was missed in a file move

Bug: chromium:991547
Change-Id: I4442f2e4e7acdb91b16151714b87e229bce1a409
Reviewed-on: chromium-review.googlesource.com/c/v8/v8/+/1824945
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63968}

Refs: v8/v8@01e52d8

This also should remove build warnings on windows.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Oct 18, 2019
@gengjiawen gengjiawen changed the title deps: V8: cherry-pick I4442f2 deps: V8: cherry-pick 01e52d8 Oct 18, 2019
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should refer to the upstream change. Please follow https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md for V8 cherry-picks and backports.

See v8/v8@01e52d8.
This also should remove build warnings on windows.

We don't use the gn files to build Node.js.

@gengjiawen
Copy link
Member Author

Commit message should refer to the upstream change.

Due to gfw, I can't use git node v8 backport <sha>, so I do this manually, Can you check again if I miss something, thanks.

We don't use the gn files to build Node.js.

I am aware of this, but on windows, there is still a warning for this. And other related toolchain also effect.

@gengjiawen gengjiawen requested a review from richardlau October 18, 2019 06:50
@gengjiawen
Copy link
Member Author

Close this in favor of #30020.

@gengjiawen gengjiawen closed this Oct 18, 2019
@gengjiawen gengjiawen deleted the v8/patch branch October 18, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants