Skip to content

Conversation

@guybedford
Copy link
Contributor

Resolves #30650.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Nov 26, 2019
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 27, 2019
@MylesBorins
Copy link
Contributor

fast-track ?

@addaleax
Copy link
Member

Landed in 50ab2e3

@addaleax addaleax closed this Nov 27, 2019
@addaleax addaleax deleted the guybedford-patch-1 branch November 27, 2019 23:14
addaleax pushed a commit that referenced this pull request Nov 27, 2019
PR-URL: #30651
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Nov 30, 2019
PR-URL: #30651
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@targos
Copy link
Member

targos commented Jan 13, 2020

depends on #29866 to land on v12.x-staging

@MylesBorins
Copy link
Contributor

@targos we can skip this PR actually as self resolve is unflagged (behind experimental-modules) on 12.x already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: --experimental-modules entry in Command Line Options is wrong

10 participants