Skip to content

stream: removed outdated TODO #31701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ronag wants to merge 1 commit into from
Closed

stream: removed outdated TODO #31701

ronag wants to merge 1 commit into from

Conversation

@ronag
Copy link
Member

@ronag ronag commented Feb 8, 2020

Was resolved in e559842.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 8, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29030/

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem. labels Feb 9, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 9, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29044/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 9, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29045/

@addaleax
Copy link
Member

addaleax commented Feb 13, 2020

Landed in b9a7625

@addaleax addaleax closed this Feb 13, 2020
addaleax pushed a commit that referenced this pull request Feb 13, 2020
@ronag @addaleax
stream: removed outdated TODO
b9a7625 
Was resolved in e559842.

PR-URL: #31701
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 4, 2020

as this relies on a semver-major change I marked as don't land on currently maintained branches

@BethGriggs BethGriggs mentioned this pull request Apr 14, 2020
Merged
@todo todo bot mentioned this pull request Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@lundibundi lundibundi lundibundi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ronag @nodejs-github-bot @addaleax @MylesBorins @jasnell @BridgeAR @lundibundi