Skip to content

src: clean up large pages code #33255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gabrielschulhof wants to merge 1 commit into from
Closed

src: clean up large pages code #33255

gabrielschulhof wants to merge 1 commit into from

Conversation

@gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented May 5, 2020

  • Initialize structure members.
  • Factor out common Debug() prefix.
  • Remove unused text_region field.

Signed-off-by: @gabrielschulhof

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

src: clean up large pages code
9a17045 
* Initialize structure members.
* Factor out common `Debug()` prefix.
* Remove unused `text_region` field.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
@gabrielschulhof gabrielschulhof added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 5, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 5, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31178/

@gabrielschulhof gabrielschulhof marked this pull request as ready for review May 5, 2020 21:01
jasnell
jasnell reviewed May 6, 2020
View reviewed changes
bnoordhuis
bnoordhuis approved these changes May 6, 2020
View reviewed changes
src/large_pages/node_large_page.cc
uintptr_t start = 0;
uintptr_t end = 0;
uintptr_t reference_sym = reinterpret_cast<uintptr_t>(&__node_text_start);
std::string exename = "";
Copy link
Member

@bnoordhuis bnoordhuis May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
std::string exename = "";
std::string exename;

(it's superfluous for std::string.)

gabrielschulhof pushed a commit that referenced this pull request May 8, 2020
src: clean up large pages code
fdfb98b 
* Initialize structure members.
* Factor out common `Debug()` prefix.
* Remove unused `text_region` field.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #33255
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented May 8, 2020

Landed in fdfb98b.

codebytere pushed a commit that referenced this pull request May 11, 2020
@codebytere
src: clean up large pages code
ed41494 
* Initialize structure members.
* Factor out common `Debug()` prefix.
* Remove unused `text_region` field.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #33255
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@codebytere
src: clean up large pages code
ed62d43 
* Initialize structure members.
* Factor out common `Debug()` prefix.
* Remove unused `text_region` field.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #33255
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Merged
@gabrielschulhof gabrielschulhof deleted the large-pages-code-cleanup branch January 28, 2021 00:14
@gabrielschulhof gabrielschulhof restored the large-pages-code-cleanup branch January 28, 2021 05:33
@gabrielschulhof gabrielschulhof deleted the large-pages-code-cleanup branch February 3, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell left review comments

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@addaleax addaleax addaleax approved these changes

+1 more reviewer

@devnexen devnexen devnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gabrielschulhof @nodejs-github-bot @bnoordhuis @jasnell @addaleax @devnexen