Skip to content

quic: set up FunctionTemplates more cleanly #33968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 1 commit into from
Closed

quic: set up FunctionTemplates more cleanly #33968

addaleax wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Jun 19, 2020

  • Use kInternalFieldCount, similar to 0fac393.
  • Always inherit from the correct parent template, similar to 8a7201b.
  • Always provide a template class name.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
quic: set up FunctionTemplates more cleanly
34f7858 
- Use `kInternalFieldCount`, similar to 0fac393.
- Always inherit from the correct parent template, similar to 8a7201b.
- Always provide a template class name.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jun 19, 2020
jasnell
jasnell approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Long standing todo off my list 🥇

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 22, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 22, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32023/

jasnell pushed a commit that referenced this pull request Jun 22, 2020
@addaleax @jasnell
quic: set up FunctionTemplates more cleanly
1b7434d 
- Use `kInternalFieldCount`, similar to 0fac393.
- Always inherit from the correct parent template, similar to 8a7201b.
- Always provide a template class name.

PR-URL: #33968
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 22, 2020

Landed in 1b7434d

@jasnell jasnell closed this Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@addaleax @nodejs-github-bot @jasnell @codebytere