Skip to content

process: stricter sourceMappingURL regex #34305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcoe wants to merge 0 commits into from
Closed

process: stricter sourceMappingURL regex #34305

bcoe wants to merge 0 commits into from

Conversation

@bcoe
Copy link
Contributor

@bcoe bcoe commented Jul 11, 2020

The library brrp, which itself processes source maps, had its processing logic erroneously loaded as a source map URL.

Refs: bcoe/c8#232

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@bcoe bcoe requested review from Fishrock123 and addaleax July 11, 2020 04:57
@bcoe bcoe mentioned this pull request Jul 11, 2020
Merged
4 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 12, 2020 •
edited by bcoe
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32296/ ✅

@bcoe bcoe closed this Jul 16, 2020
@bcoe bcoe mentioned this pull request Jul 16, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax Awaiting requested review from addaleax

@Fishrock123 Fishrock123 Awaiting requested review from Fishrock123

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bcoe @nodejs-github-bot @jasnell