Skip to content

fs: use Promise.resolve from primordials #35379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
targos wants to merge 1 commit into from
Closed

fs: use Promise.resolve from primordials #35379

targos wants to merge 1 commit into from

Conversation

@targos
Copy link
Member

@targos targos commented Sep 27, 2020

No description provided.

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Sep 27, 2020
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 27, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33262/

@addaleax
Copy link
Member

addaleax commented Sep 29, 2020

Looks like this needs a rebase

@targos targos force-pushed the promise-primordials branch from a9e1432 to 05c1988 Compare September 30, 2020 06:32
targos added a commit that referenced this pull request Sep 30, 2020
@targos
fs: use Promise.resolve from primordials
6c91991 
PR-URL: #35379
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos
Copy link
Member Author

targos commented Sep 30, 2020

Landed in 6c91991

@targos targos closed this Sep 30, 2020
@targos targos deleted the promise-primordials branch September 30, 2020 06:33
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@targos @danielleadams
fs: use Promise.resolve from primordials
e4a4f81 
PR-URL: #35379
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@targos @joesepi
fs: use Promise.resolve from primordials
3a2db56 
PR-URL: nodejs#35379
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+2 more reviewers

@watilde watilde watilde approved these changes

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@targos @nodejs-github-bot @addaleax @lpinca @watilde @cjihrig @devsnek