Skip to content

timers: refactor to use rest parameter #35947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 2 commits into from
Closed

timers: refactor to use rest parameter #35947

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fadc581
timers: refactor to use rest parameter
aduh95 Nov 3, 2020
4a9de0b
fixup! timers: refactor to use rest parameter
aduh95 Dec 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 11 additions & 21 deletions lib/timers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@
'use strict';

const {
ArrayPrototypeSlice,
MathTrunc,
ObjectCreate,
ObjectDefineProperty,
SafeArrayIterator,
SymbolToPrimitive
} = primordials;

Expand Down Expand Up @@ -131,10 +133,10 @@ function enroll(item, msecs) {
* DOM-style timers
*/

function setTimeout(callback, after, arg1, arg2, arg3) {
function setTimeout(callback, after, arg1, arg2, ...arg3) {
validateCallback(callback);

let i, args;
let args;
switch (arguments.length) {
// fast cases
case 1:
Expand All @@ -147,11 +149,7 @@ function setTimeout(callback, after, arg1, arg2, arg3) {
args = [arg1, arg2];
break;
default:
args = [arg1, arg2, arg3];
for (i = 5; i < arguments.length; i++) {
// Extend array dynamically, makes .apply run much faster in v6.0.0
args[i - 2] = arguments[i];
}
args = [arg1, arg2, ...new SafeArrayIterator(arg3)];
break;
}

Expand Down Expand Up @@ -185,10 +183,10 @@ function clearTimeout(timer) {
}
}

function setInterval(callback, repeat, arg1, arg2, arg3) {
function setInterval(callback, repeat, arg1, arg2, ...arg3) {
validateCallback(callback);

let i, args;
let args;
switch (arguments.length) {
// fast cases
case 1:
Expand All @@ -201,11 +199,7 @@ function setInterval(callback, repeat, arg1, arg2, arg3) {
args = [arg1, arg2];
break;
default:
args = [arg1, arg2, arg3];
for (i = 5; i < arguments.length; i++) {
// Extend array dynamically, makes .apply run much faster in v6.0.0
args[i - 2] = arguments[i];
}
args = [arg1, arg2, ...new SafeArrayIterator(arg3)];
break;
}

Expand Down Expand Up @@ -236,10 +230,10 @@ Timeout.prototype[SymbolToPrimitive] = function() {
return id;
};

function setImmediate(callback, arg1, arg2, arg3) {
function setImmediate(callback, arg1, arg2) {
validateCallback(callback);

let i, args;
let args;
switch (arguments.length) {
// fast cases
case 1:
Expand All @@ -251,11 +245,7 @@ function setImmediate(callback, arg1, arg2, arg3) {
args = [arg1, arg2];
break;
default:
args = [arg1, arg2, arg3];
for (i = 4; i < arguments.length; i++) {
// Extend array dynamically, makes .apply run much faster in v6.0.0
args[i - 1] = arguments[i];
}
args = ArrayPrototypeSlice(arguments, 1);
break;
}

Expand Down