Skip to content

cluster: restructure to same prototype for cluster child #36610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yashLadha wants to merge 1 commit into from
Closed

cluster: restructure to same prototype for cluster child #36610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions lib/internal/cluster/child.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,13 @@ cluster._getServer = function(obj, options, cb) {
if (typeof obj._setServerData === 'function')
obj._setServerData(reply.data);

if (handle)
shared(reply, handle, indexesKey, index, cb); // Shared listen socket.
else
rr(reply, indexesKey, index, cb); // Round-robin.
if (handle) {
// Shared listen socket
shared(reply, { handle, indexesKey, index }, cb);
} else {
// Round-robin.
rr(reply, { indexesKey, index }, cb);
}
});

obj.once('listening', () => {
Expand All @@ -129,7 +132,7 @@ function removeIndexesKey(indexesKey, index) {
}

// Shared listen socket.
function shared(message, handle, indexesKey, index, cb) {
function shared(message, { handle, indexesKey, index }, cb) {
const key = message.key;
// Monkey-patch the close() method so we can keep track of when it's
// closed. Avoids resource leaks when the handle is short-lived.
Expand All @@ -146,8 +149,8 @@ function shared(message, handle, indexesKey, index, cb) {
cb(message.errno, handle);
}

// Round-robin. Primary distributes handles across workers.
function rr(message, indexesKey, index, cb) {
// Round-robin. Master distributes handles across workers.
function rr(message, { indexesKey, index }, cb) {
if (message.errno)
return cb(message.errno, null);

Expand Down