Skip to content

test: account for OOM risks in heapsnapshot-near-heap-limit tests #37761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Trott merged 1 commit into from
Mar 20, 2021
Merged

test: account for OOM risks in heapsnapshot-near-heap-limit tests #37761

Trott merged 1 commit into from
Mar 20, 2021

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Mar 15, 2021 •
edited
Loading

Fixes: #36961

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 15, 2021
@joyeecheung
Copy link
Member Author

joyeecheung commented Mar 15, 2021

stress test: https://ci.nodejs.org/job/node-stress-single-test/225/

@joyeecheung
Copy link
Member Author

joyeecheung commented Mar 16, 2021

stress test for the worker one: https://ci.nodejs.org/job/node-stress-single-test/226/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 16, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36733/

@RaisinTen
Copy link
Member

RaisinTen commented Mar 16, 2021

Nit: Should we use this in the commit message so that the related issue gets closed when this lands?

Fixes: https://github.com/nodejs/node/issues/36961

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 18, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36776/

@joyeecheung @Trott
test: account for OOM risks in heapsnapshot-near-heap-limit tests
a41c3e1 
PR-URL: nodejs#37761
Fixes: nodejs#36961
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott merged commit a41c3e1 into nodejs:master Mar 20, 2021
@Trott
Copy link
Member

Trott commented Mar 20, 2021

Landed in a41c3e1

ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
@joyeecheung @ruyadorno
test: account for OOM risks in heapsnapshot-near-heap-limit tests
9f61cbd 
PR-URL: #37761
Fixes: #36961
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos pushed a commit that referenced this pull request Aug 8, 2021
@joyeecheung @targos
test: account for OOM risks in heapsnapshot-near-heap-limit tests
53b225a 
PR-URL: #37761
Fixes: #36961
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Aug 12, 2021
@joyeecheung @BethGriggs
test: account for OOM risks in heapsnapshot-near-heap-limit tests
abf1410 
PR-URL: #37761
Fixes: #36961
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 31, 2021
@joyeecheung @MylesBorins
test: account for OOM risks in heapsnapshot-near-heap-limit tests
c6ab198 
PR-URL: #37761
Fixes: #36961
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@joyeecheung @foxxyz
test: account for OOM risks in heapsnapshot-near-heap-limit tests
e47a985 
PR-URL: nodejs#37761
Fixes: nodejs#36961
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@marsonya marsonya marsonya approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate flaky test/parallel/test-heapsnapshot-near-heap-limit.js

6 participants

@joyeecheung @nodejs-github-bot @RaisinTen @Trott @marsonya @targos