Skip to content

crypto: forbid NODE-ED25519 and NODE-ED448 "raw" key export #38668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panva wants to merge 1 commit into from
Closed

crypto: forbid NODE-ED25519 and NODE-ED448 "raw" key export #38668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/internal/crypto/webcrypto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,8 +288,11 @@ async function exportKeyRaw(key) {
case 'NODE-ED25519':
// Fall through
case 'NODE-ED448':
return lazyRequire('internal/crypto/ec')
.ecExportKey(key, kWebCryptoKeyFormatRaw);
if (key.type === 'public') {
return lazyRequire('internal/crypto/ec')
.ecExportKey(key, kWebCryptoKeyFormatRaw);
}
break;
case 'ECDSA':
// Fall through
case 'ECDH':
Expand Down
15 changes: 6 additions & 9 deletions test/parallel/test-webcrypto-ed25519-ed448.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,15 +268,12 @@ async function test2(namedCurve) {
true, ['verify']),
]);

const [
rawKey1,
rawKey2,
] = await Promise.all([
subtle.exportKey('raw', privateKey),
subtle.exportKey('raw', publicKey),
]);
assert.deepStrictEqual(Buffer.from(rawKey1), vector.privateKey);
assert.deepStrictEqual(Buffer.from(rawKey2), vector.publicKey);
const rawPublicKey = await subtle.exportKey('raw', publicKey);
assert.deepStrictEqual(Buffer.from(rawPublicKey), vector.publicKey);

assert.rejects(subtle.exportKey('raw', privateKey), {
message: new RegExp(`Unable to export a raw ${namedCurve} private key`)
}).then(common.mustCall());

const sig = await subtle.sign(
{ name: namedCurve },
Expand Down