node-api: correctly return pending exception status on napi_new_instance #38798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are any JavaScript exceptions pending, `napi_pending_exception` should be returned.
github-actions
bot
added
c++
bl-ue
reviewed
May 24, 2021
Comment on lines
+64
to
+65
| // Ignore status and check napi_is_exception_pending() instead. | ||
|
|
Contributor
There was a problem hiding this comment.
This comment looks a bit misplaced. Am I correct?
Suggested change
| // Ignore status and check napi_is_exception_pending() instead. | |
| // Ignore status and check napi_is_exception_pending() instead. |
Member
Author
There was a problem hiding this comment.
Eh, maybe not. The comment is actually for the line above, which means that the omitting of the checks on the returning status is intentional.
Contributor
There was a problem hiding this comment.
Ah, I see. Perhaps it would be better to put the comment above the call (and the variable declaration)? If this is a convention in the codebase no problem then.
addaleax
approved these changes
May 26, 2021
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
mhdawson
pushed a commit
that referenced
this pull request
Jun 4, 2021
When there are any JavaScript exceptions pending, `napi_pending_exception` should be returned. PR-URL: #38798 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>
Member
|
Landed in 78af363 |
Contributor
|
@mhdawson for my own education: did you shorten |
Merged
Member
|
This needs #37217 to land on v14.x first (or needs to be manually backported). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are any JavaScript exceptions pending,
napi_pending_exceptionshould be returned.Related: nodejs/node-addon-api#1000