Skip to content

src: add not-weak DCHECK to PersistentToLocal::Strong #38875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 1 commit into from
Closed

src: add not-weak DCHECK to PersistentToLocal::Strong #38875

addaleax wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented May 31, 2021

@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 31, 2021
@addaleax addaleax removed the needs-ci PRs that need a full CI run. label May 31, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 31, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38405/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 1, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38428/

addaleax added a commit that referenced this pull request Jun 3, 2021
@addaleax
src: add not-weak DCHECK to PersistentToLocal::Strong
62493e9 
Refs: #38821 (comment)

PR-URL: #38875
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@addaleax
Copy link
Member Author

addaleax commented Jun 3, 2021

Landed in 62493e9

@addaleax addaleax closed this Jun 3, 2021
@addaleax addaleax deleted the persistent-to-local-strong-dcheck branch June 3, 2021 10:16
targos pushed a commit that referenced this pull request Jun 11, 2021
@addaleax @targos
src: add not-weak DCHECK to PersistentToLocal::Strong
db4b192 
Refs: #38821 (comment)

PR-URL: #38875
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@addaleax @richardlau
src: add not-weak DCHECK to PersistentToLocal::Strong
84178ec 
Refs: #38821 (comment)

PR-URL: #38875
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@addaleax @richardlau
src: add not-weak DCHECK to PersistentToLocal::Strong
bfd2368 
Refs: #38821 (comment)

PR-URL: #38875
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@addaleax @richardlau
src: add not-weak DCHECK to PersistentToLocal::Strong
ff7cc8f 
Refs: #38821 (comment)

PR-URL: #38875
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@addaleax @foxxyz
src: add not-weak DCHECK to PersistentToLocal::Strong
206e38e 
Refs: nodejs#38821 (comment)

PR-URL: nodejs#38875
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bengl bengl bengl approved these changes

@Qard Qard Qard approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@Flarna Flarna Flarna approved these changes

+1 more reviewer

@bl-ue bl-ue bl-ue approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@addaleax @nodejs-github-bot @bengl @Qard @jasnell @cjihrig @tniessen @Flarna @bl-ue