Skip to content

Conversation

@Trott
Copy link
Member

@Trott Trott commented Aug 10, 2021

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 10, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 10, 2021
@Trott Trott changed the title tools: update path-parse in markdown linter tools: update path-parse in markdown linter package-lock file Aug 11, 2021
@Trott
Copy link
Member Author

Trott commented Aug 11, 2021

This changes the package-lock.json but not the resulting lint-md.js file because path-parse is in a devDependency and the update does not affect the output of the build script.

@Trott Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Aug 13, 2021
@Trott
Copy link
Member Author

Trott commented Aug 13, 2021

48 hours has passed so this no longer needs a fast-track, but it could use a second review/approval..... @nodejs/linting

@targos
Copy link
Member

targos commented Aug 13, 2021

What is changed in lint-md.js? The mobile UI just shows -0 +0

@nschonni
Copy link
Member

The execute bit was set. It's now 755

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2021
@github-actions
Copy link
Contributor

Landed in ae0cfc9...1150cfe

@github-actions github-actions bot closed this Aug 13, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 13, 2021
Refs: GHSA-hj48-42vr-x3v9

PR-URL: #39729
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
Refs: GHSA-hj48-42vr-x3v9

PR-URL: #39729
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Refs: GHSA-hj48-42vr-x3v9

PR-URL: #39729
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Trott Trott deleted the path-parse branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants