Skip to content

tools: use {N} for spaces in regex #41295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Dec 23, 2021
Merged

tools: use {N} for spaces in regex #41295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tools/find-inactive-collaborators.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const authors = await runGitCommand(
// Get all approving reviewers of landed commits during the time period.
const approvingReviewers = await runGitCommand(
`git log --since="${SINCE}" | egrep "^ Reviewed-By: "`,
(line) => /^ Reviewed-By: ([^<]+)/.exec(line)[1].trim()
(line) => /^ {4}Reviewed-By: ([^<]+)/.exec(line)[1].trim()
);

async function getCollaboratorsFromReadme() {
Expand All @@ -72,7 +72,7 @@ async function getCollaboratorsFromReadme() {
foundCollaboratorHeading = true;
}
if (line.startsWith(' **') && isCollaborator) {
const [, name, email] = /^ \*\*([^*]+)\*\* <<(.+)>>/.exec(line);
const [, name, email] = /^ {2}\*\*([^*]+)\*\* <<(.+)>>/.exec(line);
const mailmap = await runGitCommand(
`git check-mailmap '${name} <${email}>'`
);
Expand Down Expand Up @@ -136,7 +136,7 @@ async function moveCollaboratorToEmeritus(peopleToMove) {
if (line.startsWith('* ')) {
collaboratorFirstLine = line;
} else if (line.startsWith(' **')) {
const [, name, email] = /^ \*\*([^*]+)\*\* <<(.+)>>/.exec(line);
const [, name, email] = /^ {2}\*\*([^*]+)\*\* <<(.+)>>/.exec(line);
if (peopleToMove.some((entry) => {
return entry.name === name && entry.email === email;
})) {
Expand Down