[v16.x backport] readline: add Promise-based API

.eslintrc.js

@@ -163,7 +163,7 @@ module.exports = {
     'keyword-spacing': 'error',
     'linebreak-style': ['error', 'unix'],
     'max-len': ['error', {
-      code: 80,
+      code: 120,
       ignorePattern: '^// Flags:',
       ignoreRegExpLiterals: true,
       ignoreTemplateLiterals: true,
@@ -186,7 +186,6 @@ module.exports = {
     'no-proto': 'error',
     'no-redeclare': ['error', { 'builtinGlobals': false }],
     'no-restricted-modules': ['error', 'sys'],
-    /* eslint-disable max-len */
     'no-restricted-properties': [
       'error',
       {
@@ -239,7 +238,6 @@ module.exports = {
         message: 'Use Number.isNaN() instead of the global isNaN() function.',
       },
     ],
-    /* eslint-enable max-len */
     'no-return-await': 'error',
     'no-self-compare': 'error',
     'no-tabs': 'error',
@@ -297,10 +295,7 @@ module.exports = {
     'valid-typeof': ['error', { requireStringLiterals: true }],
 
     // ESLint recommended rules that we disable
-    'no-cond-assign': 'off',
-    'no-empty': 'off',
     'no-inner-declarations': 'off',
-    'no-prototype-builtins': 'off',
 
     // JSDoc recommended rules that we disable
     'jsdoc/require-jsdoc': 'off',

.github/CODEOWNERS

@@ -13,9 +13,7 @@
 /CODE_OF_CONDUCT.md @nodejs/tsc
 /CONTRIBUTING.md @nodejs/tsc
 /LICENSE @nodejs/tsc
-/doc/guides/contributing/*.md @nodejs/tsc
-/doc/guides/collaborator-guide.md @nodejs/tsc
-/doc/guides/offboarding.md @nodejs/tsc
+/doc/contributing/*.md @nodejs/tsc
 
 # streams
 
@@ -88,7 +86,7 @@
 
 /src/node_api* @nodejs/node-api
 /src/js_native_api* @nodejs/node-api
-/doc/guides/adding-new-napi-api.md @nodejs/node-api
+/doc/contributing/adding-new-napi-api.md @nodejs/node-api
 /doc/api/n-api.md @nodejs/node-api
 
 # gyp

.github/ISSUE_TEMPLATE/2-feature-request.yml

@@ -8,6 +8,9 @@ body:
         Thank you for suggesting an idea to make Node.js better.
 
         Please fill in as much of the following form as you're able.
+
+        For more information on how the project manages feature
+        requests, see [Feature request management](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md).
   - type: textarea
     attributes:
       label: What is the problem this feature will solve?

.github/PULL_REQUEST_TEMPLATE.md

@@ -3,7 +3,7 @@ Before submitting a pull request, please read
 https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.
 
 Commit message formatting guidelines:
-https://github.com/nodejs/node/blob/HEAD/doc/guides/contributing/pull-requests.md#commit-message-guidelines
+https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
 
 For code changes:
 1. Include tests for any bug fixes or new features.

.github/workflows/auto-start-ci.yml

@@ -5,7 +5,7 @@ on:
     # Runs every five minutes (fastest the scheduler can run). Five minutes is
     # optimistic, it can take longer to run.
     # To understand why `schedule` is used instead of other events, refer to
-    # ./doc/guides/commit-queue.md
+    # ./doc/contributing/commit-queue.md
     - cron: "*/5 * * * *"
 
 env:

.github/workflows/build-windows.yml

@@ -26,11 +26,7 @@ env:
 jobs:
   build-windows:
     if: github.event.pull_request.draft == false
-    strategy:
-      matrix:
-        windows: [windows-2019, windows-2022]
-      fail-fast: false
-    runs-on: ${{ matrix.windows }}
+    runs-on: windows-2019
     steps:
       - uses: actions/checkout@v2
         with:

.github/workflows/coverage-windows.yml

@@ -31,7 +31,7 @@ env:
 jobs:
   coverage-windows:
     if: github.event.pull_request.draft == false
-    runs-on: windows-latest
+    runs-on: windows-2019
     steps:
       - uses: actions/checkout@v2
         with:

.gitignore

@@ -159,3 +159,6 @@ install_manifest.txt
 __pycache__
 .DS_Store
 *~
+
+# === Rules for C++ development ===
+compile_commands.json

.mailmap

@@ -4,6 +4,8 @@ Aaron Heckmann <aaron.heckmann@gmail.com> <aaron.heckmann+github@gmail.com>
 Aayush Ahuja <aayush.a@directi.com>
 Abe Fettig <abefettig@gmail.com> <abe@fettig.net>
 Abhimanyu Vashisht <abhimanyuvashisht.av@gmail.com>
+Akhil Marsonya <akhil.marsonya27@gmail.com>
+Akhil Marsonya <akhil.marsonya27@gmail.com> <16393876+marsonya@users.noreply.github.com>
 Akito Ito <akito0107@gmail.com> <akito_ito@r.recruit.co.jp>
 Alejandro Estrada <estrada9166@gmail.com>
 Alejandro Estrada <estrada9166@gmail.com> <estrada9166@hotmail.com>
@@ -112,6 +114,7 @@ Daniel Paulino <d_paulino@outlook.com>
 Daniel Pihlström <sciolist.se@gmail.com>
 Daniel Wang <wangyang0123@gmail.com>
 Daniel Wang <wangyang0123@gmail.com> <wangyang02@baidu.com>
+Danielle Adams <adamzdanielle@gmail.com> <6271256+danielleadams@users.noreply.github.com>
 Danielle Adams <adamzdanielle@gmail.com> <danielle.adams@heroku.com>
 Danny Guo <danny@dannyguo.com> <dannyguo91@gmail.com>
 Danny Nemer <hi@dannynemer.com> <DannyNemer@users.noreply.github.com>
@@ -231,6 +234,8 @@ Jerry Chin <qinjia@outlook.com>
 Jessica Quynh Tran <jessica.quynh.tran@gmail.com>
 Jesús Leganés-Combarro 'piranna <piranna@gmail.com>
 Jimb Esser <wasteland@gmail.com> <jimb@railgun3d.com>
+Jithil P Ponnan <jithil@outlook.com>
+Jithil P Ponnan <jithil@outlook.com> <MrJithil@users.noreply.github.com>
 Jochen Eisinger <jochen@chromium.org> 
 Joe Shaw <joe@joeshaw.org> <joeshaw@litl.com>
 Johan Bergström <bugs@bergstroem.nu>
@@ -323,6 +328,7 @@ Matthew Turner <matty_t47@hotmail.com> <ramesius@users.noreply.github.com>
 Matthias Bastian <dev@matthias-bastian.de> <piepmatz@users.noreply.github.com>
 Maurice Hayward <mauricehayward1@gmail.com>
 Maya Lekova <apokalyptra@gmail.com> <mslekova@chromium.org>
+Mestery <mestery@protonmail.com> <mestery@pm.me>
 Michael Bernstein <michaelrbernstein@gmail.com>
 Michael Dawson <midawson@redhat.com> <mdawson@devrus.com>
 Michael Dawson <midawson@redhat.com> <michael_dawson@ca.ibm.com>
@@ -379,6 +385,7 @@ Qingyu Deng <i@ayase-lab.com> <bitdqy@hotmail.com>
 Rachel White <loveless@gmail.com>
 Ratikesh Misra <ratikesh92@gmail.com>
 Ravindra Barthwal <ravindrabarthwal@users.noreply.github.com>
+Ray <rayw.public@gmail.com> <ray@isrc.iscas.ac.cn>
 Ray Morgan <rmorgan@zappos.com>
 Ray Solomon <raybsolomon@gmail.com>
 Raymond Feng <enjoyjava@gmail.com> <raymond@strongloop.com>
@@ -528,6 +535,8 @@ xiaoyu <306766053@qq.com>
 Xu Meng <dmabupt@gmail.com> <mengxumx@cn.ibm.com>
 Yael Hermon <yaelherm@gmail.com> <yaelhe@wix.com>
 Yang Guo <yangguo@chromium.org>
+Yash Ladha <yash@yashladha.in> <18033231+yashLadha@users.noreply.github.com>
+Yash Ladha <yash@yashladha.in> <yashladhapankajladha123@gmail.com>
 ycjcl868 <45808948@qq.com> <chaolinjin@gmail.com>
 Yingchen Xue <yingchenxue@qq.com>
 Yongsheng Zhang <zyszys98@gmail.com>

AUTHORS

@@ -3027,7 +3027,7 @@ Christian Niederer <aqpoba@gmail.com>
 Sk Sajidul Kadir <sheikh.sajid522@gmail.com>
 Bartlomiej Brzozowski <bart.brzozowski@janeasystems.com>
 Saajan <saajan.sn@gmail.com>
-Yash Ladha <yashladhapankajladha123@gmail.com>
+Yash Ladha <yash@yashladha.in>
 Alex R <alexei.rudenko@gmail.com>
 Hachimi Aa (Sfeir) <hachimi.aa@sfeir.com>
 Daniel Estiven Rico Posada <danielrico.posada@gmail.com>
@@ -3220,7 +3220,7 @@ Akash Negi <55234838+NegiAkash890@users.noreply.github.com>
 James Addison <jay@jp-hosting.net>
 Fabian Cook <hello@fabiancook.dev>
 Kalvin Vasconcellos <kalvin.vasconcellos@gmail.com>
-marsonya <akhil.marsonya27@gmail.com>
+Akhil Marsonya <akhil.marsonya27@gmail.com>
 Qingyu Deng <i@ayase-lab.com>
 Matin Zadehdolatabad <zadehdolatabad@gmail.com>
 Daniel Clark <daniec@microsoft.com>
@@ -3272,7 +3272,7 @@ Arnold Zokas <arnold.zokas@coderoom.net>
 Nils Dralle <nils.91@googlemail.com>
 Jesse Chan <jc@linux.com>
 helloyou2012 <helloyou2012@yeah.net>
-MrJithil <jithil@outlook.com>
+Jithil P Ponnan <jithil@outlook.com>
 Rodolfo Carvalho <rhcarvalho@gmail.com>
 Jordan Baczuk <JBaczuk@users.noreply.github.com>
 moander <moander@outlook.com>
@@ -3310,7 +3310,7 @@ nerdthatnoonelikes <kenrag24@gmail.com>
 Nikita Rykov <40735471+angrymouse@users.noreply.github.com>
 Benjamin Mayr <b.mayr@cognigy.com>
 Lew Gordon <lew.gordon@genesys.com>
-Mestery <mestery@pm.me>
+Mestery <mestery@protonmail.com>
 Himadri Ganguly <himadri.tech@gmail.com>
 Howie Zhao <howiezhaohr@hotmail.com>
 Luan Devecchi <luan@engineer.com>
@@ -3319,7 +3319,7 @@ Justin <justinleeong@gmail.com>
 Raz Luvaton <rluvaton@gmail.com>
 Don Jayamanne <don.jayamanne@yahoo.com>
 Felix Yan <felixonmars@archlinux.org>
-Ray <ray@isrc.iscas.ac.cn>
+Ray <rayw.public@gmail.com>
 Node.js GitHub Bot <github-bot@iojs.org>
 Alexey Ten <alexeyten@gmail.com>
 JckXia <ys3xia@uwaterloo.ca>
@@ -3396,5 +3396,22 @@ Wayne Zhang <zsw007@gmail.com>
 nikoladev <15011519+nikoladev@users.noreply.github.com>
 Antonio Román <kyradiscord@gmail.com>
 JoostK <joost.koehoorn@gmail.com>
+Yu <yu521088@gmail.com>
+Shi Pujin <shipujin.t@gmail.com>
+Daoming Qiu <daoming.qiu@intel.com>
+Job <Manduro@users.noreply.github.com>
+Alex Agranov <v-alagra@microsoft.com>
+Shalvah <shalvah@users.noreply.github.com>
+Gabriel Trujillo <joaqt23@gmail.com>
+LiviaMedeiros <livia@cirno.name>
+iMoses <imoses.g@gmail.com>
+Harshil jain <twitharshil@gmail.com>
+Tobias Hernstig <30827238+thernstig@users.noreply.github.com>
+Ben McCann <322311+benmccann@users.noreply.github.com>
+Caio Agiani <agianicaio@gmail.com>
+Ateş Göral <ates@magnetiq.com>
+Tony Gorez <gorez.tony@gmail.com>
+ofirbarak <ofirbirka@gmail.com>
+Bar Admoni <bar6020677@gmail.com>
 
 # Generated by tools/update-authors.js

BUILDING.md

@@ -219,9 +219,10 @@ Supported platforms and toolchains change with each major version of Node.js.
 This document is only valid for the current major version of Node.js.
 Consult previous versions of this document for older versions of Node.js:
 
+* [Node.js 17](https://github.com/nodejs/node/blob/v17.x/BUILDING.md)
+* [Node.js 16](https://github.com/nodejs/node/blob/v16.x/BUILDING.md)
 * [Node.js 14](https://github.com/nodejs/node/blob/v14.x/BUILDING.md)
 * [Node.js 12](https://github.com/nodejs/node/blob/v12.x/BUILDING.md)
-* [Node.js 10](https://github.com/nodejs/node/blob/v10.x/BUILDING.md)
 
 ## Building Node.js on supported platforms
 

CONTRIBUTING.md

@@ -5,28 +5,28 @@
 * [Pull Requests](#pull-requests)
 * [Developer's Certificate of Origin 1.1](#developers-certificate-of-origin)
 
-## [Code of Conduct](./doc/guides/contributing/code-of-conduct.md)
+## [Code of Conduct](./doc/contributing/code-of-conduct.md)
 
 The Node.js project has a
 [Code of Conduct](https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md)
 to which all contributors must adhere.
 
-See [details on our policy on Code of Conduct](./doc/guides/contributing/code-of-conduct.md).
+See [details on our policy on Code of Conduct](./doc/contributing/code-of-conduct.md).
 
-## [Issues](./doc/guides/contributing/issues.md)
+## [Issues](./doc/contributing/issues.md)
 
-* [Asking for General Help](./doc/guides/contributing/issues.md#asking-for-general-help)
-* [Discussing non-technical topics](./doc/guides/contributing/issues.md#discussing-non-technical-topics)
-* [Submitting a Bug Report](./doc/guides/contributing/issues.md#submitting-a-bug-report)
-* [Triaging a Bug Report](./doc/guides/contributing/issues.md#triaging-a-bug-report)
+* [Asking for General Help](./doc/contributing/issues.md#asking-for-general-help)
+* [Discussing non-technical topics](./doc/contributing/issues.md#discussing-non-technical-topics)
+* [Submitting a Bug Report](./doc/contributing/issues.md#submitting-a-bug-report)
+* [Triaging a Bug Report](./doc/contributing/issues.md#triaging-a-bug-report)
 
-## [Pull Requests](./doc/guides/contributing/pull-requests.md)
+## [Pull Requests](./doc/contributing/pull-requests.md)
 
-* [Dependencies](./doc/guides/contributing/pull-requests.md#dependencies)
-* [Setting up your local environment](./doc/guides/contributing/pull-requests.md#setting-up-your-local-environment)
-* [The Process of Making Changes](./doc/guides/contributing/pull-requests.md#the-process-of-making-changes)
-* [Reviewing Pull Requests](./doc/guides/contributing/pull-requests.md#reviewing-pull-requests)
-* [Notes](./doc/guides/contributing/pull-requests.md#notes)
+* [Dependencies](./doc/contributing/pull-requests.md#dependencies)
+* [Setting up your local environment](./doc/contributing/pull-requests.md#setting-up-your-local-environment)
+* [The Process of Making Changes](./doc/contributing/pull-requests.md#the-process-of-making-changes)
+* [Reviewing Pull Requests](./doc/contributing/pull-requests.md#reviewing-pull-requests)
+* [Notes](./doc/contributing/pull-requests.md#notes)
 
 <a id="developers-certificate-of-origin"></a>
 

GOVERNANCE.md

@@ -25,7 +25,7 @@ Triagers are given the "Triage" GitHub role and have:
 See:
 
 * [List of triagers](./README.md#triagers)
-* [A guide for triagers](./doc/guides/contributing/issues.md#triaging-a-bug-report)
+* [A guide for triagers](./doc/contributing/issues.md#triaging-a-bug-report)
 
 ## Collaborators
 
@@ -54,7 +54,7 @@ result in collaborators removing their opposition.
 See:
 
 * [List of collaborators](./README.md#current-project-team-members)
-* [A guide for collaborators](./doc/guides/collaborator-guide.md)
+* [A guide for collaborators](./doc/contributing/collaborator-guide.md)
 
 ### Collaborator activities