gyp: fix direct run gyp bug #42986
Closed
gyp: fix direct run gyp bug #42986
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
targos
previously requested changes
May 6, 2022
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
Please upstream to nodejs/gyp-next
Member
Author
Sadly the original changes (introduced by openssl 3) only in this repo for now. #40735 |
Member
|
Ah, that's unfortunate :( |
Member
Author
|
directly add it to nodejs/gyp-next#147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #40518 (comment)
Repro:
python3 tools/gyp_node.py -f cmake