deps: update undici to 5.10.0 #44319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dependencies
tniessen
approved these changes
Aug 21, 2022
Trott
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Author
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
VoltrexKeyva
approved these changes
Aug 21, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Author
Member
|
@nodejs/undici this seems to break with a container/machine without OpenSSL: |
aduh95
removed
fast-track
github-actions
bot
removed
the
request-ci
Collaborator
Author
Collaborator
Author
nodejs-github-bot
removed
the
commit-queue
Collaborator
Author
Commit Queue failed- Loading data for nodejs/node/pull/44319 ✔ Done loading data for nodejs/node/pull/44319 ----------------------------------- PR info ------------------------------------ Title deps: update undici to 5.10.0 (#44319) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-undici -> nodejs:main Labels dependencies Commits 2 - deps: update undici to 5.9.1 - deps: update undici to 5.10.0 Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/44319 Reviewed-By: Tobias Nießen Reviewed-By: Rich Trott Reviewed-By: Antoine du Hamel Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44319 Reviewed-By: Tobias Nießen Reviewed-By: Rich Trott Reviewed-By: Antoine du Hamel Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 21 Aug 2022 00:25:37 GMT ✔ Approvals: 5 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/44319#pullrequestreview-1079603475 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44319#pullrequestreview-1079613718 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/44319#pullrequestreview-1079649039 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/44319#pullrequestreview-1079681960 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/44319#pullrequestreview-1082864768 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-08-24T06:29:58Z: https://ci.nodejs.org/job/node-test-pull-request/46206/ - Querying data for job/node-test-pull-request/46206/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 44319 From https://github.com/nodejs/node * branch refs/pull/44319/merge -> FETCH_HEAD ✔ Fetched commits as 7900f6540ea8..2c4f9d3c69cc -------------------------------------------------------------------------------- [main dc75916a9f] deps: update undici to 5.9.1 Date: Sun Aug 21 00:25:34 2022 +0000 9 files changed, 132 insertions(+), 37 deletions(-) [main 5573e8557f] deps: update undici to 5.10.0 Date: Tue Aug 23 21:26:28 2022 +0000 8 files changed, 214 insertions(+), 36 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/2917091493 |
nodejs-github-bot
added
the
commit-queue-failed
MoLow
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
Collaborator
Author
|
Landed in cfdc713 |
This was referenced Aug 24, 2022
|
The commit message and changelog entry are " deps: update undici to 5.9.1", but the PR is "deps: update undici to 5.10.0" and the PR contains actual change to 5.10.0. |
Merged
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of undici to 5.10.0