Skip to content

deps: update OpenSSL 3.0.6+quic #44972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RafaelGSS wants to merge 2 commits into from
Closed

deps: update OpenSSL 3.0.6+quic #44972

RafaelGSS wants to merge 2 commits into from

Conversation

@RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Oct 11, 2022

Updated openssl dep to openssl-3.0.6+quic using the maintenance guide.

Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-October/000234.html

@RafaelGSS
deps: upgrade openssl sources to quictls/openssl-3.0.6+quic
8cee6cb 
This updates all sources in deps/openssl/openssl by:
    $ git clone git@github.com:quictls/openssl.git
    $ cd openssl
    $ git checkout openssl-3.0.6+quic
    $ cd ../node/deps/openssl
    $ rm -rf openssl
    $ cp -R ../../../openssl openssl
    $ rm -rf openssl/.git* openssl/.travis*
    $ git add --all openssl
    $ git commit openssl
@RafaelGSS
deps: update archs files for quictls/openssl-3.0.6+quic
037ca05 
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
    $ make -C deps/openssl/config clean
    $ make -C deps/openssl/config
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/openssl
    $ git commit
@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels Oct 11, 2022
@RafaelGSS RafaelGSS added request-ci Add this label to start a Jenkins CI on a PR. dont-land-on-v16.x labels Oct 11, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 11, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47190/

@danielleadams danielleadams added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022

Fast-track has been requested by @danielleadams. Please 👍 to approve.

@danielleadams danielleadams removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2022
@richardlau
Copy link
Member

richardlau commented Oct 11, 2022

This appears to have several failing crypto and webcrypto tests 😞.

@github-actions github-actions bot mentioned this pull request Oct 12, 2022
Open
19 tasks
@RafaelGSS RafaelGSS closed this Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danielleadams danielleadams danielleadams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RafaelGSS @nodejs-github-bot @richardlau @danielleadams