Skip to content

http2: fix crash on Http2Stream::diagnostic_name() #45123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Oct 25, 2022
Merged

http2: fix crash on Http2Stream::diagnostic_name() #45123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/node_http2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2060,9 +2060,12 @@ void Http2Stream::MemoryInfo(MemoryTracker* tracker) const {
}

std::string Http2Stream::diagnostic_name() const {
const Http2Session* sess = session();
const std::string sname =
sess ? sess->diagnostic_name() : "session already destroyed";
return "HttpStream " + std::to_string(id()) + " (" +
std::to_string(static_cast<int64_t>(get_async_id())) + ") [" +
session()->diagnostic_name() + "]";
std::to_string(static_cast<int64_t>(get_async_id())) + ") [" + sname +
"]";
}

// Notify the Http2Stream that a new block of HEADERS is being processed.
Expand Down