Skip to content

test: revise pull request guide text about code #45519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Nov 19, 2022
Merged

test: revise pull request guide text about code #45519

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27e92a0
test: revise pull request guide text about code
Trott Nov 19, 2022
5374a5c
fixup! test: revise pull request guide text about code
Trott Nov 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions doc/contributing/pull-requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,13 @@ git checkout -b my-branch -t upstream/HEAD

### Step 3: Code

The vast majority of pull requests opened against the `nodejs/node`
repository includes changes to one or more of the following:
Pull requests in Node.js typically involve changes to
one or more of a few places in the repository.

* the C/C++ code contained in the `src` directory
* the JavaScript code contained in the `lib` directory
* the documentation in `doc/api`
* tests within the `test` directory.
* C/C++ code contained in the `src` directory
* JavaScript code contained in the `lib` directory
* Documentation in `doc/api`
* Tests within the `test` directory

If you are modifying code, please be sure to run `make lint` (or
`vcbuild.bat lint` on Windows) to ensure that the changes follow the Node.js
Expand Down