Skip to content

doc: using console.error for error cases in crypto and events #45640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Dec 7, 2022
Merged

doc: using console.error for error cases in crypto and events #45640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e90f13c
doc: using console.error for error cases in crypto and events
emirgoren Nov 27, 2022
61dbaed
fixed line
emirgoren Nov 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/api/crypto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ let crypto;
try {
crypto = require('node:crypto');
} catch (err) {
console.log('crypto support is disabled!');
console.error('crypto support is disabled!');
}
```

Expand All @@ -67,7 +67,7 @@ let crypto;
try {
crypto = await import('node:crypto');
} catch (err) {
console.log('crypto support is disabled!');
console.error('crypto support is disabled!');
}
```

Expand Down
8 changes: 4 additions & 4 deletions doc/api/events.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,7 +1041,7 @@ process.nextTick(() => {
try {
await once(ee, 'myevent');
} catch (err) {
console.log('error happened', err);
console.error('error happened', err);
}
```

Expand All @@ -1066,7 +1066,7 @@ async function run() {
try {
await once(ee, 'myevent');
} catch (err) {
console.log('error happened', err);
console.error('error happened', err);
}
}

Expand All @@ -1085,7 +1085,7 @@ const ee = new EventEmitter();

once(ee, 'error')
.then(([err]) => console.log('ok', err.message))
.catch((err) => console.log('error', err.message));
.catch((err) => console.error('error', err.message));

ee.emit('error', new Error('boom'));

Expand All @@ -1099,7 +1099,7 @@ const ee = new EventEmitter();

once(ee, 'error')
.then(([err]) => console.log('ok', err.message))
.catch((err) => console.log('error', err.message));
.catch((err) => console.error('error', err.message));

ee.emit('error', new Error('boom'));

Expand Down