src: fail CommonEnvironmentSetup if environment bootstrapping failed #46797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Member
|
Mh this might be a duplicate of #46533? The approach there is a bit more complete because it passes along the actual error message (but also does a quite a bit of work in order to be able to do so) |
Member
Author
|
Ah, thanks. Closing as duplicated. |
addaleax
added
the
duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
Environmentis failed to bootstrap at development time (e.g. syntax errors or uncaught exceptions in the JavaScript bootstrapping codes), theCommonEnvironmentSetup::CreateForSnapshottingshould return anullptrinstead of aCommonEnvironmentSetupwith a nullptrenvmember, which would lead to invalid access.Unfortunately, I'm not aware of a method to run an unhappy path in bootstrapping to add a test case for this behavior.