Skip to content

Conversation

@targos
Copy link
Member

@targos targos commented Mar 30, 2023

We don't want (yet?) to consider coverage as a requirement for landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status

We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: nodejs#47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 30, 2023
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 1, 2023
@nodejs-github-bot nodejs-github-bot merged commit d918bf4 into nodejs:main Apr 1, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in d918bf4

@targos targos deleted the codecov-status branch April 1, 2023 07:10
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: nodejs#47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: nodejs#47306
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants