tools: simplify update-openssl workflow #48185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
meta
marco-ippolito
force-pushed
the
feat/simplify-openssl-update
branch
from
bee2187 to
63cb220
Compare
aduh95
reviewed
May 26, 2023
aduh95
reviewed
May 26, 2023
marco-ippolito
commented
May 26, 2023
aduh95
reviewed
May 26, 2023
marco-ippolito
force-pushed
the
feat/simplify-openssl-update
branch
from
bba2e8a to
a6b65ff
Compare
RafaelGSS
reviewed
May 28, 2023
RafaelGSS
approved these changes
Jun 6, 2023
Member
RafaelGSS
left a comment
RafaelGSS
left a comment
There was a problem hiding this comment.
If there's no intention to support openssl 1.x in this PR. LGTM.
marco-ippolito
force-pushed
the
feat/simplify-openssl-update
branch
from
a6b65ff to
ea36d86
Compare
marco-ippolito
added
the
author ready
Member
Author
|
superseded by #48377 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a lot of noise from the github action and allows to run the update script without specifying a version.
Unlike other dependencies we want to keep the update with the specified target version for backporting security patches to v16 which is no longer compatible with the version on main.