Skip to content

Conversation

@popmoore
Copy link
Contributor

  • Fix esm doc format

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels May 26, 2024
@deokjinkim
Copy link
Contributor

deokjinkim commented May 27, 2024

@popmoore Thank you for your contribution. Please replace docs with doc in commit title.
Below is guidelines for commit message.
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

@popmoore popmoore changed the title docs: fix esm markdown file doc: fix esm markdown file May 27, 2024
@popmoore
Copy link
Contributor Author

@popmoore Thank you for your contribution. Please replace docs with doc in commit title. Below is guidelines for commit message. https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

Hi @deokjinkim I changed the commit title, can you approve the CI workflows

@deokjinkim deokjinkim added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2024
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label May 27, 2024
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@deokjinkim

This comment was marked as off-topic.

@aduh95

This comment was marked as off-topic.

@aduh95 aduh95 merged commit 72a4470 into nodejs:main May 27, 2024
@aduh95
Copy link
Contributor

aduh95 commented May 27, 2024

Landed in 72a4470

targos pushed a commit that referenced this pull request Jun 1, 2024
PR-URL: #53170
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
ebouye pushed a commit to ebouye/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#53170
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
PR-URL: nodejs#53170
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #53170
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #53170
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants