repl: handle object patterns without values #53331
Merged
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Member
|
@lukehaas Can you please address the lint errors? |
BridgeAR
approved these changes
Jun 5, 2024
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM
Thank you for the fix and congratulations to your first contribution!
Member
|
Ideally, you could still force push with a commit message that adheres to our commit message standard. In this case e.g., |
github-actions
bot
removed
the
request-ci
Collaborator
fix lint issue
lukehaas
force-pushed
the
fix-reply-await-bug
branch
from
86a199d to
7b557e3
Compare
Contributor
Author
|
@BridgeAR thanks. I've updated the commit message. |
cola119
approved these changes
Jun 6, 2024
github-actions
bot
removed
the
request-ci
Collaborator
cola119
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 479b8e5 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jun 7, 2024
fix lint issue PR-URL: #53331 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Merged
ebouye
pushed a commit
to ebouye/node
that referenced
this pull request
Jun 20, 2024
fix lint issue PR-URL: nodejs#53331 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
fix lint issue PR-URL: nodejs#53331 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
fix lint issue PR-URL: #53331 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
fix lint issue PR-URL: #53331 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53328
For the
ObjectPatternof typeRestElementthe child node is in theargumentproperty.